PR: Rename QtDatavisualization to use uppercase v #228
Conversation
Both `PyQt5` and `PySide2` call the module QtDatavisualization (with an
uppercase V) and the `tests/test_qtdatavisualization.py` file even
does `pytest.importorskip("qtpy.QtDataVisualization")` which means the
test is always skipped since the module didn't exist.
Another solution would be to fix the test but for homogeneity with
PyQt5 and PySide2 I think it's better to rename QtDatavisualization.py
to QtDataVisualization.py .
|
Should QtPy provide an alias set in |
There might be applications using the wrong name. This commit introduces an alias so they keep working as usual.
There was a problem hiding this comment.
Makes sense to me, esp. with the backward compat. However, I am kinda unclear on the PR description; you say
Both
PyQt5andPySide2call the module QtDatavisualization (with an uppercase v)
but while you say they call the module "with an uppercase v", the actual text written there as to what they call the module has a lowercase v, so I'm a bit confused. Other than that, LGTM FWIW once we get the CIs running again (not sure what happened with them).
|
Oops, that's a very unfortunate typo. I should have written QtDataVisualization indeed. |
There was a problem hiding this comment.
Thanks; FWIW, LGTM. You might need to repush (e.g. git commit --amend --no-edit && git push -f) to trigger the checks once PR #208 is merged, which should hopefully happen shortly.
ccordoba12
changed the title
|
Closing (and reopening) to check if a CI rerun is triggered |
Both
PyQt5andPySide2call the module QtDatavisualization (with an uppercase v) and thetests/test_qtdatavisualization.pyfile even doespytest.importorskip("qtpy.QtDataVisualization")which means the test is currently always skipped since the module didn't exist.Another solution would be to fix the test but for homogeneity with PyQt5 and PySide2 I think it's better to rename QtDatavisualization.py to QtDataVisualization.py .