Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Prefer format() over string interpolation operator" issue #23

Merged
merged 2 commits into from
Jun 2, 2016

Conversation

goanpeca
Copy link
Member

This pull request automatically fixes all occurrences of the following issue:

Issue type: Prefer format() over string interpolation operator
Issue details: https://www.quantifiedcode.com/app/project/gh:spyder-ide:qtpy?groups=code_patterns/%3A4ACGxFj1

To adjust the commit message or the actual code changes, just rebase or cherry-pick the commits.
For questions or feedback reach out to cody@quantifiedcode.com.

Legal note: We won't claim any copyrights on the code changes.

Cheers,
Cody - Your code quality bot

@goanpeca
Copy link
Member Author

@spyder-ide/core-developers testing a new tool called quantified code.

Its pretty cool :-)

@Nodd
Copy link
Contributor

Nodd commented May 23, 2016

The tool looks cool, but I'd reject this pull request because:

  1. String interpolation is not bad for small string like these
  2. It's not what a human would write, the tool was careful to keep the exact same functionality but in both cases {0} is enough.

@ccordoba12
Copy link
Member

I agree with @Nodd: using {0} is enough in both cases.

@ccordoba12 ccordoba12 added this to the v1.0.2 milestone Jun 2, 2016
@ccordoba12
Copy link
Member

I did the changes myself to be able to release 1.0.2 (which I need to better support QtWebEngine in 5.6 :-)

@ccordoba12 ccordoba12 merged commit ba75893 into master Jun 2, 2016
@ccordoba12 ccordoba12 deleted the autofix/wrapped2_to3_fix branch June 2, 2016 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants