qtpy/uic.py: Make compatible with python3.9 #239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
|
seems to be a duplicate of #224 still: good to make some noise for @ccordoba12 @andfoy ;) |
|
Hi @irrcombat thank you for you contribution and sorry for the late feedback! However as @hiaselhans mentions there is already #224 and checking the tracker even an older PR (#204) Taking this into account I will close this one but for sure a fix for the compatibility and a release with it needs to be done :) Thank you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #238
Signed-off-by: Andrew Ammerlaan andrewammerlaan@gentoo.org