Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Fix fallback API #256

Merged
merged 1 commit into from
Oct 18, 2021
Merged

PR: Fix fallback API #256

merged 1 commit into from
Oct 18, 2021

Conversation

benoit-pierre
Copy link
Contributor

Since PyQt4 support was removed, use pyqt5 as fallback, otherwise, if no supported API is available:

qtpy/__init__.py:194: in <module>
    API_NAME = {'pyqt6': 'PyQt6', 'pyqt5': 'PyQt5',
E   KeyError: 'pyqt'

@ccordoba12 ccordoba12 changed the title fix fallback API PR: Fix fallback API Oct 17, 2021
@ccordoba12 ccordoba12 added this to the v2.0.0 milestone Oct 17, 2021
dalthviz
dalthviz approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@dalthviz dalthviz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @benoit-pierre for noticing this! This LGTM 👍🏼

@dalthviz dalthviz merged commit 32f4a9f into spyder-ide:master Oct 18, 2021
@benoit-pierre benoit-pierre deleted the fix_fallback_api branch October 18, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalthviz dalthviz dalthviz approved these changes

Assignees

@benoit-pierre benoit-pierre

Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@benoit-pierre @dalthviz @ccordoba12