-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tests.py into proper unit test, and add Qt version info to pytest header #28
Conversation
This is now ready for review! (I think the quantifiedcode warnings can be ignored in this case) |
Great work @astrofrog, :-) |
@astrofrog, thanks a lot for working on this! It's a great improvement :-) @goanpeca, please disable QuantifiedCode. |
assert_pyqt4() | ||
elif QT_API == 'pyqt5': | ||
assert_pyqt5() | ||
else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to enter this part if we set always set USE_QT_API
in travis.yml
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not on Travis or AppVeyor, but it's possible if one runs the tests locally without specifying USE_QT_API or QT_API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
@ccordoba12 - do you need me to squash the commits? (not sure what kind of policy you use for qtpy compared to other projects) |
…d QT_API are not defined.
@ccordoba12 the quantified code suggestions are valid
I will disable the one that complaints about having non pythonic method names which does not work when using Qt. @astrofrog could you make the suggested "fixes"? |
Ok, I think this one is ready. We have to merge it with AppVeyor failing because there's no AppVeyor working at this point :-) |
Since I'm adding actual tests in #25 and #27, I thought it would make sense to formally switch over to using py.test to run tests. This also makes it so that the py.test header includes detailed Qt version information: