Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Update README sponsors section #282

Merged
merged 3 commits into from
Nov 21, 2021
Merged

PR: Update README sponsors section #282

merged 3 commits into from
Nov 21, 2021

Conversation

dalthviz
Copy link
Member

No description provided.

@dalthviz dalthviz added this to the v2.0.0 milestone Nov 17, 2021
@dalthviz dalthviz self-assigned this Nov 17, 2021
@CAM-Gerlach
Copy link
Member

Hey @dalthviz , was this intended to be a draft PR? Looks like the inline image isn't rendering; otherwise, everything LGTM so far 👍

@dalthviz dalthviz changed the title [WIP] PR: Update README sponsors section PR: Update README sponsors section Nov 18, 2021
ccordoba12
ccordoba12 reviewed Nov 18, 2021
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the Numfocus logo next to the Quansight one (as we do in our other repos).

Also, is there a Quasight logo with a transparent background we could use? I think it'd be nicer than having one with white background.

CAM-Gerlach
CAM-Gerlach approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dalthviz !

ccordoba12
ccordoba12 approved these changes Nov 21, 2021
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit b1d1bae into spyder-ide:master Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

Assignees

@dalthviz dalthviz

Labels
type:Task
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dalthviz @CAM-Gerlach @ccordoba12