-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add a warning for developers still running legacy Qt4-based APIs #283
Conversation
Looks like the CIs are not running at all. I'll see if I can fix that... |
The issue is the old CI job, before my improvements, only runs on |
(So, incidentally, PR #281 skipped the tests and checks completely) |
288dbe8
to
c8fd4b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @CAM-Gerlach!
I amended it into the same commit, to hopefully make it a little easier when merging to |
@ccordoba12 Want me to merge when the CIs pass, or should we wait for @dalthviz ? |
Is there any need to merge |
@dalthviz, you can still merge with |
Ah, I somehow forgot that |
We will now warn developers (via a
DeprecationWarning
, so they have to be running Python with-X dev
,-W default
or-W error
, or import QtPy in their__main__
script) when they are using long-deprecated, soon to be removed Qt4 based APIs (PySide and PyQt4), either via their explictly set preference, via import, or via a default fallback if installed, all of which will be unsupported come QtPy 2.0.Resolves #261