PR: Use QFileDialog.Option to be compatiable with Qt6 #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthviz
approved these changes
Apr 5, 2022
There was a problem hiding this comment.
Thank you @frmdstryr for noticing this and submitting a fix! This LGTM 👍 However what do you think @ccordoba12 @CAM-Gerlach ?
ccordoba12
approved these changes
Apr 5, 2022
ccordoba12
changed the title
|
Since we got two approvals I will go ahead and merge this one. Thank you again @frmdstryr for your help 👍 |
|
Thanks! |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QFileDialog.Optionsdoes not exist on Qt6.Tested with PyQt5 5.15.2 and PyQt6 6.2.3