Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Restore WEBENGINE constant in QtWebEngineWidgets #350

Merged
merged 1 commit into from
Jun 13, 2022
Merged

PR: Restore WEBENGINE constant in QtWebEngineWidgets #350

merged 1 commit into from
Jun 13, 2022

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Jun 13, 2022 •
edited
Loading

This constant was removed in PR #344, but it's used by external projects (e.g. Spyder). So, they would break if they can't find it.

@ccordoba12 ccordoba12 added this to the v2.2.0 milestone Jun 13, 2022
@ccordoba12 ccordoba12 requested a review from dalthviz June 13, 2022 15:07
@ccordoba12 ccordoba12 self-assigned this Jun 13, 2022
dalthviz
dalthviz approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccordoba12 LGTM 👍

@dalthviz dalthviz merged commit 246dab0 into spyder-ide:master Jun 13, 2022
@ccordoba12 ccordoba12 deleted the restore-webengine-constant branch June 13, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalthviz dalthviz dalthviz approved these changes

Assignees

@ccordoba12 ccordoba12

Labels
type:Bug
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ccordoba12 @dalthviz @CAM-Gerlach