Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Aliased QUndoCommand, provided QLineEdit.getTextMargins() and QFontMetricsF.width() #366

Conversation

random-developer
Copy link
Contributor

@random-developer random-developer commented Sep 2, 2022

Fixes #365

@dalthviz dalthviz changed the title Aliased QUndoCommand, provided QLineEdit.getTextMargins() and QFontMe… PR: Aliased QUndoCommand, provided QLineEdit.getTextMargins() and QFontMe… Sep 2, 2022
@dalthviz dalthviz changed the title PR: Aliased QUndoCommand, provided QLineEdit.getTextMargins() and QFontMe… PR: Aliased QUndoCommand, provided QLineEdit.getTextMargins() and QFontMetricsF.width() Sep 2, 2022
@dalthviz dalthviz added this to the v2.2.1 milestone Sep 2, 2022
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @random-developer for your help with this! I think the only missing thing here is to add some testing:

Other than that this looks good to me 👍

@random-developer
Copy link
Contributor Author

The QUndoCommand test is failing. I'm not sure why; will investigate later; too pressed for time right now.

qtpy/tests/test_qtgui.py Outdated Show resolved Hide resolved
@random-developer random-developer force-pushed the rd-QUndoCommand-QLineEdit-QFontMetricsF branch 2 times, most recently from dd4ab16 to 4430e95 Compare September 3, 2022 16:01
@random-developer random-developer force-pushed the rd-QUndoCommand-QLineEdit-QFontMetricsF branch from 4430e95 to 458e3de Compare September 3, 2022 16:13
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @random-developer ! This LGTM 👍

@dalthviz dalthviz merged commit 0b5b6dc into spyder-ide:master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants