-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Expand the CI test matrix with Qt/bindings 6.4 and fix tests with PyQt 5.9 #376
Conversation
Thanks for the help with this @CAM-Gerlach ! After a quick review seems like this also has things related with #345 right? Regarding the failing test I think is related with
|
133ab22
to
c5e8f7b
Compare
12008e3
to
09f33e1
Compare
09f33e1
to
cb12676
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @CAM-Gerlach and @dalthviz!
It seems this has the initial steps to add pre-commit
to this repo, but I see no harm in including them for now.
Oops...I had another branch in progress adding pre-commit based on the config in our other repos, but it seems because those were new/untracked files I accidentally committed them to the wrong branch when I was working on this, and then got busy with the Python 3.11 release and didn't notice my WiP config was added here. Sorry about that and thanks @dalthviz for finishing this up! |
I will push to and test this incrementally, starting with setting one job to 6.4 for bindings and Qt, and see how things go. If we need to fix a lot of failures (which I might need your help on @dalthviz ), we can merge this once that's done and then add the optional deps in a separate PR, since that can be significantly more complex.
Fixes #375
Part of #345