PR: Enable more qt6 tests #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschueller
force-pushed
the
qt6t
branch
6 times, most recently
from
3041046
to
769615f
Compare
dalthviz
reviewed
Oct 24, 2022
There was a problem hiding this comment.
Thanks @jschueller for working on this! I left some comments/suggestions regarding the commented asserts for modules only available on Qt5 bindings. Also, left a question regarding the installation of GStreamer for Linux.
Other than that this LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the disabled classes QCameraViewfinder, QSGAbstractRenderer& QSGEngine are qt5-only