Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Skip QtPositioning tests on Conda Qt >=6.4.3 where its not included #414

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

CAM-Gerlach
Copy link
Member

@CAM-Gerlach CAM-Gerlach commented Mar 18, 2023

As discovered in PR #413 , as of the release of qt-main 6.4.3 on Conda-Forge (conda-forge/qt-main-feedstock#135), the Qt6 Conda jobs are failing because QtPositioning is no longer included in qt-main as of 6.4.3, along with the other QSensors stuff for device sensors.

Therefore, I just went ahead and skipped the test on QT6 and conda. It might be nice to be able to actually check the version, though for that we really should do a proper version comparison on the QT_VERSION (for which it would be a good idea to parse it and the other versions in __init__ to "version_info"-style version tuples, e.g. under QT_VERSION_INFO and similar, which might be more generally useful to users and ourselves. However, since that would be a slightly less trivial change, I deferred that until getting your feedback on it.

Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CAM-Gerlach ! LGTM 👍

As a side note, regarding the QT_VERSION parsing that sounds like a good idea 👍 Although I'm not sure if that should be done for at least a minor release 🤔 , maybe creating an issue to track the idea would be good (so we can get more feedback first).

@CAM-Gerlach
Copy link
Member Author

As a side note, regarding the QT_VERSION parsing that sounds like a good idea +1 Although I'm not sure if that should be done for at least a minor release thinking , maybe creating an issue to track the idea would be good (so we can get more feedback first).

Thanks; opened as #415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants