Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Make exec() for PySide2 #438

Merged
merged 1 commit into from
Jul 5, 2023
Merged

PR: Make exec() for PySide2 #438

merged 1 commit into from
Jul 5, 2023

Conversation

StSav012
Copy link
Contributor

@StSav012 StSav012 commented Jul 5, 2023

To make the new code compatible with PySide2, I've made exec() for the classes that have exec_() functions:

  • QCoreApplication
  • QEventLoop
  • QThread
  • QTextStreamManipulator

And tests for the calls. Actually, test_qtextstreammanipulator_exec and test_qthread_exec are far from perfect, but I haven't figured out how to test them.

@StSav012 StSav012 marked this pull request as ready for review July 5, 2023 11:46
@ccordoba12 ccordoba12 requested a review from dalthviz July 5, 2023 12:40
@ccordoba12 ccordoba12 added this to the v2.4.0 milestone Jul 5, 2023
dalthviz
dalthviz approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @StSav012 ! LGTM 👍

@dalthviz dalthviz merged commit b303b62 into spyder-ide:master Jul 5, 2023
@dalthviz dalthviz changed the title Make exec() for PySide2 PR: Make exec() for PySide2 Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalthviz dalthviz dalthviz approved these changes

Assignees

@StSav012 StSav012

Labels
type:Enhancement
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@StSav012 @dalthviz @ccordoba12