-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Setup pre-commit and format all code with Black #451
Conversation
@dalthviz I think that best option for smooth experience is to setup pre-commit.ci on this repository. |
Thank you so much for the help here @Czaki ! I think using |
Thanks for giving us a hand with this @Czaki! One important thing to mention is that I think all changes in this PR should be squashed in a single commit and when everything is ready for merge, that commit should be added to |
ded4236
to
c26c552
Compare
Squased. I hope that all imports that I removed by mistake are found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work @Czaki ! I left some comments regarding the new contribution guide pre-commit
entry, and some code comments which seems like either need to be removed now or due to imports changing order need to be moved along side the new place the imports is.
Besides that I noticed a removed PySide6
import inside a test that maybe could be worthy to check locally but other than that this LGTM 👍 Again thank you so much for helping us with this!
c26c552
to
4b12ece
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Czaki !
This PR setup pre commit with following hooks:
closes #345