Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download links now broken in Spyder 6 & fix error w/stylelint #378

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

CAM-Gerlach
Copy link
Member

@CAM-Gerlach CAM-Gerlach commented Sep 4, 2024

Pull Request

Pull Request Checklist

  • Read and followed this repo's Contributing Guidelines
  • Based your PR on the latest version of the correct branch (master or 4.x)
  • Checked your writing carefully for correct English spelling, grammar, etc
  • Described your changes and the motivation for them below
  • Noted what issue(s) this pull request resolves, creating one if needed

Description of Changes

Discovered in and blocks PR #377

When Spyder 6 was released earlier today, the existing download links all broke due to the changes to the filenames to make them more consistent, as well as some of the extensions, and the new Spyder website without a separate download section. Therefore, we've fixed these issues as well as adding a new Linux installer button.

Technically this is going in before the Spyder 5 branch gets cut, but as the Spyder 5 links would be broken anyway (we'd have to hardcode them to the latest version) and are of increasingly dubious various for new users now that Spyder 6 is (nominally) stable, and this is blocking other PRs that we want to apply to the Spyder 5 docs as well (i.e. for the translations that we've already done), I'm going and merging this to master before cutting that branch.

Additionally, I've fixed something else that's broken in the meantime and causing the lint check to fail, the stylelint-no-unsupported-browser-features check causing stylelint to crash due to a change in caniuse ( RJWadley/stylelint-no-unsupported-browser-features/issues#299 ), by pinning the latter dependency to a known good version.

@CAM-Gerlach CAM-Gerlach added type:Task type:Spyder Change 6.x Issues specific to the 6.x branch labels Sep 4, 2024
@CAM-Gerlach CAM-Gerlach self-assigned this Sep 4, 2024
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment for you @CAM-Gerlach, the rest looks good to me.

doc/installation.rst Outdated Show resolved Hide resolved
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CAM-Gerlach!

@ccordoba12 ccordoba12 merged commit 5f68368 into spyder-ide:master Sep 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.x Issues specific to the 6.x branch type:Spyder Change type:Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants