-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Use an outstream with isatty() equal to True #305
Conversation
Interestingly the edited file already imports and uses
Besides that I would approve this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @eendebakpt, thanks for your help with this! I left an initial review for you.
@ccordoba12 Thanks for the feedback. I addressed the comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @eendebakpt, I think this is almost ready! Besides the comment I left for you below, please make your branch to derive from our 2.x
branch (instead of master
), with the following commands:
git checkout 2.x
git checkout feat/isatty
git rebase --onto 2.x master feat/isatty
git push -f origin feat/isatty
That will allow me to include this feature in our next version of Spyder-kernels.
Co-authored-by: yfprojects <62463991+real-yfprojects@users.noreply.github.com>
Co-authored-by: yfprojects <62463991+real-yfprojects@users.noreply.github.com>
Co-authored-by: yfprojects <62463991+real-yfprojects@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your help @eendebakpt!
This PR is work to enable colored output (by default) in the Spyder console. See spyder-ide/spyder#1917, Textualize/rich#1221, ipython/ipykernel#683
Fixes #302
It adds
traitlets
as a new requirement, but sinceipykernel
already has this as a requirement this should have little impact.@ccordoba12