Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Migration to Spyder 5 new API #255

Merged
merged 31 commits into from
Jun 15, 2021
Merged

PR: Migration to Spyder 5 new API #255

merged 31 commits into from
Jun 15, 2021

Conversation

steff456
Copy link
Member

@steff456 steff456 commented May 6, 2021 •
edited by ccordoba12
Loading

This PR is still in progress:

  • Create the skeleton of the new API
  • Fix missing new terminal button in toolbar
  • Fix duplicate shortcuts entries in preferences
  • Fix Select All focus when triggered by the context menu
  • Fix the non-saving layout
  • Fix closing spyder bug
  • Fix test fixtures
  • Fix tests using getTerminalLines
  • Pin the version of Spyder 5 in the setup.py and requirements

Fixes #253
Fixes #252

image

image

@steff456 steff456 requested a review from ccordoba12 May 6, 2021 06:49
@steff456 steff456 self-assigned this May 6, 2021
@steff456
Fix botton for new term in the toolbar
87568d5
@steff456
add newer python versions to the CIs
d10964c
@steff456
fix tests
cceabee
@steff456
Pin Spyder 5.0.0 version in setup and requirements
f77fa4c
@steff456
upgrade pinned versions for terinado and pywinpty
2ee4c0c
@steff456
remove PyQT4 and Pyside
f98338a
@steff456
change vm for windows
8e867e2
@steff456
Fix on_close bug
6440cdd
@steff456
fix duplicate shortcuts
3150b6a
@steff456
fix getTerminalLines function
e42b624
@steff456
Remove select all functions
36df5c6
@steff456
Increase Spyder supported version
e47caf7
@steff456
Pin pytest-qt version
5c0a3e1
@steff456
pin pytest version
109e501
@steff456
change test installation channel
7b42d4a
@steff456
Pin pytest-qt to 3.3.0
b30c7fb
@steff456
fix typo
2f19805
@steff456
upgrade linux vm
1db87bf
@steff456
skip test in linux
72f7788
@steff456
skip test in linux and add flaky to unstable test
193245e
@steff456
use windows latest
0daf36f
@steff456
Remove CondaEnvironment@0
0a11d0f
@steff456
add conda activate
93deee1
@steff456
Change conda to call
9ab3c82
@steff456
activate environment in windows
12e90fe
@steff456
Skip resize test in windows
ba49b50
@steff456
activate env for coverage
8196e2f
@ccordoba12 ccordoba12 changed the title PR: Migration of Spyder 5's new API PR: Migration to Spyder 5's new API Jun 15, 2021
@ccordoba12 ccordoba12 changed the title PR: Migration to Spyder 5's new API PR: Migration to Spyder 5 new API Jun 15, 2021
@steff456 steff456 marked this pull request as ready for review June 15, 2021 01:04
ccordoba12
ccordoba12 reviewed Jun 15, 2021
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here @steff456! I left some minor comments for you, otherwise it looks pretty good.

setup.py Show resolved Hide resolved
spyder_terminal/api.py Outdated Show resolved Hide resolved
spyder_terminal/config.py Outdated Show resolved Hide resolved
spyder_terminal/widgets/main_widget.py Show resolved Hide resolved
spyder_terminal/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder_terminal/widgets/main_widget.py Show resolved Hide resolved
spyder_terminal/widgets/terminalgui.py Outdated Show resolved Hide resolved
spyder_terminal/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder_terminal/terminalplugin.py Outdated Show resolved Hide resolved
ccordoba12
ccordoba12 approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @steff456 for this!

@ccordoba12 ccordoba12 merged commit cc8fab6 into spyder-ide:master Jun 15, 2021
@ccordoba12 ccordoba12 added this to the 1.0.0 milestone Jun 15, 2021
@dalthviz dalthviz mentioned this pull request Dec 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@steff456 steff456

Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Spyder-terminal never shows up on menu or as tabbed windows Spyder 5 support
2 participants
@steff456 @ccordoba12