Fix TextEditor constructor #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spyder-ide/spyder@e4c5b1a introduced dynamic window sizing and hence removed the size argument in the TextEditor constructor. This commit restores the previous behavior.
|
Thanks for the PR!
It does not work for me either. I opened an issue in the Spyder repo. |
|
See my comment here. Sorry for the confusion. |
|
Nice find! Please prepare a PR, if you don't mind. I actually tried removing the .resize and I saw the window was too small, just like you said. However, I did not try adding the .show, because the .exec already shows the dialog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spyder-ide/spyder@e4c5b1a introduced dynamic window sizing and hence removed the size argument in the TextEditor constructor, which results in an error here. This commit restores the previous behavior.
The dynamic sizing doesn't work for me: if I don't explicitly resize the window I end up with a window size of 278 x 242 pixel on my 1900 x 1200 double screen setup (Windows 10). If I just specify
te.show()instead ofte.resize(700, 500)then I get the same 700 x 500 window size. Maybe someone more knowledgeable about QT can get the dynamic sizing to work, but for the time being this PR just restores the old behavior.