Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Spyder from github 3.x branch when testing on Circle #80

Merged
merged 8 commits into from
Jul 18, 2017

Conversation

jitseniesen
Copy link
Member

Fixes #74 .

@jitseniesen jitseniesen added this to the v0.2 milestone Jul 16, 2017
@jitseniesen jitseniesen self-assigned this Jul 16, 2017
circle.yml Outdated
@@ -26,7 +28,7 @@ dependencies:
export PATH="$HOME/miniconda/bin:$PATH" &&
source activate test &&
conda install ciocheck -c spyder-ide &&
conda install spyder &&
pip install git+https://github.com/spyder-ide/spyder@3.x &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jitseniesen, this doesn't work because Spyder is not using setuptools, so it won't pull its dependencies.

Please take a look at what we do in spyder-notebook's circle.yml to workaround this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I did have a look and I was wondering why it was so complicated :) Thanks for the explanation.

Previous version did not work because Spyder is not using setuptools,
so it doesn't pull its dependencies.
@bilderbuchi
Copy link

#74 says you want to "also" Test against Spyder Master. Unless i read the yml xhanges wrong, this pr tests against master "instead of " release. Wouldn't it make sense to keep the test against a released version of spyder? That way also only one of your build components is a moving target,which should simplify diagnosis of broken builds.

For some reason, qtpy is now considered a local import so ciocheck
reports style errors.
@jitseniesen
Copy link
Member Author

The idea is that the Travis CI server tests against the released version while the Circle CI server tests against the development version. Your concerns about testing against two moving targets may well be justified, but I think it's worth to try it out and see how it goes.

@bilderbuchi
Copy link

Ah I see. That makes sense, although I would probably add another entry to the travis build matrix instead of having to keep yet another CI service running/maintained/configured. I guess there are other reasons to do that, though, e.g. travis build limits.

circle.yml Outdated
conda install -c spyder-ide pytest-cov &&
conda install -q -c spyder-ide pytest-cov &&
conda install -q spyder &&
conda remove -y spyder &&

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jitseniesen just FYI, the ability to install --only-deps will be coming with conda 4.4, apparently.

@jitseniesen jitseniesen merged commit b463647 into spyder-ide:master Jul 18, 2017
@jitseniesen jitseniesen deleted the test-github-spyder branch July 18, 2017 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants