Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
  • Loading branch information
hmaarrfk and ccordoba12 authored Jul 8, 2024
1 parent 55e2147 commit fc7445c
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 9 deletions.
7 changes: 0 additions & 7 deletions spyder/api/widgets/mixins.py
Original file line number Diff line number Diff line change
Expand Up @@ -667,13 +667,6 @@ class SpyderWidgetMixin(SpyderActionMixin, SpyderConfigurationObserver,
# Context name used to store actions, toolbars, toolbuttons and menus
CONTEXT_NAME = None

# Qt Web Widgets may be a heavy dependency for many packagers
# (e.g. conda-forge)
# We thus ask plugins to declare whether or not they need
# web widgets to enhance the distribution of Spyder to users
# https://github.com/spyder-ide/spyder/pull/22196#issuecomment-2189377043
REQUIRE_WEB_WIDGETS = False

def __init__(self, class_parent=None):
for attr in ['CONF_SECTION', 'PLUGIN_NAME']:
if getattr(self, attr, None) is None:
Expand Down
1 change: 0 additions & 1 deletion spyder/plugins/help/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ class Help(SpyderDockablePlugin):
CONF_FILE = False
LOG_PATH = get_conf_path(CONF_SECTION)
DISABLE_ACTIONS_WHEN_HIDDEN = False

REQUIRE_WEB_WIDGETS = True

# Signals
Expand Down
1 change: 0 additions & 1 deletion spyder/plugins/onlinehelp/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ class OnlineHelp(SpyderDockablePlugin):
CONF_FILE = False
WIDGET_CLASS = PydocBrowser
LOG_PATH = get_conf_path(NAME)

REQUIRE_WEB_WIDGETS = True

# --- Signals
Expand Down

0 comments on commit fc7445c

Please sign in to comment.