Custom layouts show panels that have ''visible=False''

[dan123456-eng]

Problem Description

Custom layouts show panels with ''visible=False'' and third-party panels that are not part of a custom layout.

Custom layout in Spyder 5.3.2 with '' visible=False'':
self.add_area([SpyderPyMR.NAME], row=3, column=1, visible=False, )

Custom layout in Spyder 5.4.0 with '' visible=False'':
self.add_area([SpyderPyMR.NAME], row=3, column=1, visible=False, )

What steps reproduce the problem?

1. View
2. Window layouts
3. layout

Versions

• Spyder version: 5.4.0
• Python version: 3.8
• Qt version:
• PyQt version:
• Operating System name/version: Windows10

[ccordoba12]

Hey @dan123456-eng, thanks for reporting. I think I introduced this regression and will try to fix it in the first version we'll release next year (5.4.2).

[dan123456-eng]

Hey @dan123456-eng, thanks for reporting. I think I introduced this regression and will try to fix it in the first version we'll release next year (5.4.2).

Thanks @ccordoba12 ! I hope to contribute more actively.

[ccordoba12]

You mean that you'd like to solve this problem? Because I can give you some pointers to get you started.

[dan123456-eng]

Quer dizer que gostaria de resolver esse problema? Porque eu posso lhe dar algumas dicas para você começar.

If you can give the tips I can try to solve. Tks

[ccordoba12]

Great! I think I could have introduced this problem when I added support to restore the visible plugins in the previous session. I did that in PR #18962.

So I'll start taking a look at that, to see if commenting that functionality fixes the issue.

[dan123456-eng]

Hello @ccordoba12 . Thanks for that tip. I'll take a look.
I commented the code snippet below and apparently the problem did not occur:

    # Restore displayed external plugins
    for plugin_id in external_plugins_to_show:
        plugin = main_window.get_plugin(plugin_id, error=False)
        if plugin:
            # Show plugin
            plugin.blockSignals(True)
            plugin.dockwidget.show()
            plugin.toggle_view_action.setChecked(True)
            plugin.blockSignals(False)

            # Make visible the first plugin in the dockwidget's tab bar
            # because it should be an internal one.
            dock_tabbar = plugin.dockwidget.dock_tabbar
            if dock_tabbar:
                dock_tabbar.setCurrentIndex(0)

[dan123456-eng]

->plugin.dockwidget.show()
->plugin.toggle_view_action.setChecked(True)

[ccordoba12]

Great! I'm really glad you were able to find the solution to this issue!

Could you create a pull request for it? If you decide to do that, please don't forget to read our Contributing guide first.

If you don't comfortable with that, let us know and I can do it for you.

[dan123456-eng]

Thanks for helping! I will make the pull request.

[ccordoba12]

Nice! Thanks a lot for your help with this!