Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Update python-lsp-server subrepo and change CI Python versions #19992

Merged
merged 4 commits into from
Nov 15, 2022

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Nov 6, 2022

Description of Changes

  • Currently the python-lsp-server subrepo is pointing to the v1.6.0 tag (was needed to prevent errors on the CI tests while also being able to build the conda-based installers). This makes the subrepo point again to the develop branch
  • Change the Python version we use to test to Python 3.8 and Python 3.10

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@dalthviz dalthviz added this to the v5.4.1 milestone Nov 6, 2022
@dalthviz dalthviz self-assigned this Nov 6, 2022
@dalthviz dalthviz changed the title PR: Update python-lsp-server subrepo PR: Update python-lsp-server subrepo and change CI Python versions Nov 10, 2022
@dalthviz dalthviz changed the title PR: Update python-lsp-server subrepo and change CI Python versions [WIP] PR: Update python-lsp-server subrepo and change CI Python versions Nov 10, 2022
@dalthviz
Copy link
Member Author

Note: Needs changes on the python-lsp-server (be sure the autoimport plugin is actually disabled by default)

@ccordoba12
Copy link
Member

@dalthviz, please sync our subrepo with my branch on this PR: python-lsp/python-lsp-server#300. I verified locally that it fixes our tests here.

subrepo:
  subdir:   "external-deps/python-lsp-server"
  merged:   "6fc01fd92"
upstream:
  origin:   "https://github.com/python-lsp/python-lsp-server.git"
  branch:   "develop"
  commit:   "6fc01fd92"
git-subrepo:
  version:  "0.4.3"
  origin:   "???"
  commit:   "???"
…rver.git --branch=develop --update --force external-deps/python-lsp-server

subrepo:
  subdir:   "external-deps/python-lsp-server"
  merged:   "1b58531a4"
upstream:
  origin:   "https://github.com/python-lsp/python-lsp-server.git"
  branch:   "develop"
  commit:   "1b58531a4"
git-subrepo:
  version:  "0.4.3"
  origin:   "???"
  commit:   "???"
@dalthviz dalthviz changed the title [WIP] PR: Update python-lsp-server subrepo and change CI Python versions PR: Update python-lsp-server subrepo and change CI Python versions Nov 14, 2022
@dalthviz dalthviz requested a review from ccordoba12 November 14, 2022 18:48
@ccordoba12
Copy link
Member

Thanks for this @dalthviz! This is almost ready, except for the new problem of test_no_update_outline, which is consistently failing on Linux and Python 3.10 using pip packages. What do you propose to do about it?

@dalthviz
Copy link
Member Author

Will check what is happening. Also seems like an error is being triggered somewhere beside the test failing due to the assert?- https://github.com/spyder-ide/spyder/actions/runs/3449114058/jobs/5785585197#step:15:6037 :

Traceback (most recent call last):
  File "/home/runner/work/spyder/spyder/spyder/api/widgets/auxiliary_widgets.py", line 57, in changeEvent
    self.sig_window_state_changed.emit(self.windowState())
TypeError: SpyderWindowWidget.sig_window_state_changed[WindowStates].emit(): argument 1 has unexpected type 'WindowStates'

@ccordoba12
Copy link
Member

Also seems like an error is being triggered somewhere beside the test failing due to the assert?

Ok, I think that could be the source of the test failure at the end. You can try to change the signature of sig_window_state_changed from

sig_window_state_changed = Signal(Qt.WindowStates)

to

sig_window_state_changed = Signal(object)

and the same for the Slot argument of OutlineExplorerWidget._handle_undocked_window_state. That should solve the problem.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz for your work on this!

Note: The failures in our tests are only related to the conda-based installers.

@ccordoba12 ccordoba12 merged commit dcc4fbb into spyder-ide:5.x Nov 15, 2022
ccordoba12 added a commit that referenced this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants