-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Update python-lsp-server subrepo and change CI Python versions #19992
Conversation
Note: Needs changes on the |
@dalthviz, please sync our subrepo with my branch on this PR: python-lsp/python-lsp-server#300. I verified locally that it fixes our tests here. |
subrepo: subdir: "external-deps/python-lsp-server" merged: "6fc01fd92" upstream: origin: "https://github.com/python-lsp/python-lsp-server.git" branch: "develop" commit: "6fc01fd92" git-subrepo: version: "0.4.3" origin: "???" commit: "???"
992e32b
to
ad35ad8
Compare
…rver.git --branch=develop --update --force external-deps/python-lsp-server subrepo: subdir: "external-deps/python-lsp-server" merged: "1b58531a4" upstream: origin: "https://github.com/python-lsp/python-lsp-server.git" branch: "develop" commit: "1b58531a4" git-subrepo: version: "0.4.3" origin: "???" commit: "???"
ad35ad8
to
c7817e4
Compare
Thanks for this @dalthviz! This is almost ready, except for the new problem of |
Will check what is happening. Also seems like an error is being triggered somewhere beside the test failing due to the assert?- https://github.com/spyder-ide/spyder/actions/runs/3449114058/jobs/5785585197#step:15:6037 :
|
Ok, I think that could be the source of the test failure at the end. You can try to change the signature of sig_window_state_changed = Signal(Qt.WindowStates) to sig_window_state_changed = Signal(object) and the same for the Slot argument of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dalthviz for your work on this!
Note: The failures in our tests are only related to the conda-based installers.
Description of Changes
python-lsp-server
subrepo is pointing to the v1.6.0 tag (was needed to prevent errors on the CI tests while also being able to build the conda-based installers). This makes the subrepo point again to the develop branchAffirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: dalthviz