PR: Change pane tabs design #21071
Closed
PR: Change pane tabs design #21071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: |
…into DesignPaneTabs
…into DesignPaneTabs
|
Hey @jsbautista and @dalthviz, thanks for your work on this! Since I saw the design you decided to implement when I took a look at this PR some days ago, I also decided to resurrect some code I worked on two years ago to try to implement this feature. Now I think I have a result closer to what was discussed on spyder-ide/ux-improvements#4:
so I'd suggest we should use that instead. I'm sorry if you invested too much time on this and for not informing you about my efforts before. I just wasn't sure if I could do better than what you've done here. |
|
Is there already a PR to link as the one that supersedes this one @ccordoba12 ? |
|
See PR #21133. |
|
Closing as superseded by #21133 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Change design of pane tabs for them to look different to the tabs of the console and editor
A preview:
Tab selected:
Hover over tab not selected:
Scroll buttons when there is not enough space to show all the tabs
Issue(s) Resolved
Fixes spyder-ide/ux-improvements#4
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
@jsbautista