PR: Group kernel config calls (IPython console) #21320

impact27 · 2023-09-09T16:46:38Z

Description of Changes

Avoid sending too many messages during setup to speedup kernel opening.
Depends on PR: Simplify kernel configuration spyder-kernels#466

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

…/github.com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "c8500c6c9" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "group_config_calls" commit: "c8500c6c9" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"

impact27 · 2023-11-12T16:02:58Z

@ccordoba12 there is something wrong with qdarkstyle 3.2.1, I had to fix to 3.2.0.
There is also a failure in test_environment_client but I think this Is because of the incompatible Spyder-kernels version installed in the coda environment (get_list_conda_envs()['conda: spytest-ž'][0])

ccordoba12

Thanks @impact27!

binder/environment.yml

requirements/main.yml

setup.py

spyder/dependencies.py

spyder/plugins/ipythonconsole/confpage.py

spyder/plugins/ipythonconsole/widgets/shell.py

spyder/plugins/ipythonconsole/widgets/status.py

spyder/utils/programs.py

ccordoba12 · 2023-11-12T16:10:14Z

@ccordoba12 there is something wrong with qdarkstyle 3.2.1, I had to fix to 3.2.0.

Fixed in PR #21517.

There is also a failure in test_environment_client but I think this Is because of the incompatible Spyder-kernels version installed in the coda environment.

For that please change these lines in our install.sh script to point to your branch in Spyder-kernels:

spyder/.github/scripts/install.sh

Lines 81 to 86 in b0cfa8d

    
           # `conda run` fails on Windows without a clear reason 
        
           if [ "$OS" = "win" ]; then 
        
               /c/Miniconda/envs/spytest-ž/python -m pip install git+https://github.com/spyder-ide/spyder-kernels.git@master 
        
           else 
        
               conda run -n spytest-ž python -m pip install git+https://github.com/spyder-ide/spyder-kernels.git@master 
        
           fi

Then you'll need to revert that change when this is ready to be merged.

This reverts commit 4512721.

…com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "0a07259c3" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "group_config_calls" commit: "0a07259c3" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"

Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>

…com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "c7f38bbe7" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "group_config_calls" commit: "c7f38bbe7" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"

…onfig_calls

…com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "8297ac0d6" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "group_config_calls" commit: "8297ac0d6" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"

…com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "b7d8bdc91" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "group_config_calls" commit: "b7d8bdc91" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"

…ivation

ccordoba12 · 2023-11-14T22:14:13Z

@impact27, I pushed a commit with a similar fix to my suggestion above to see if it fixes test_environment_client.

In any case, I think it's the right thing to do for that test, so please don't remove it if it doesn't work at the end.

ccordoba12 · 2023-11-15T03:12:41Z

@impact27, I think this one is ready, unless you think there are more things to address before merging.

But I'll try it manually to see if I can spot problems missed by our tests.

…com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "3a6be2d02" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "group_config_calls" commit: "3a6be2d02" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"

impact27 · 2023-11-15T06:39:32Z

@impact27, I think this one is ready, unless you think there are more things to address before merging.

But I'll try it manually to see if I can spot problems missed by our tests.

I think this is ready

…r-kernels.git --branch=master --update --force external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "d28282944b" upstream: origin: "https://github.com/spyder-ide/spyder-kernels.git" branch: "master" commit: "d28282944b" git-subrepo: version: "0.4.3" origin: "https://github.com/ingydotnet/git-subrepo" commit: "2f68596"

ccordoba12 · 2023-11-15T23:34:47Z

Great! I merged your Spyder-kernels PR and resynced our subrepo here, so as soon as our tests pass I'll merge.

I also tested a couple of things manually (errors with special consoles and changing interactive backends) and everything seems to be working as expected. Great work!

ccordoba12

Thanks @impact27!

Quentin Peter added 7 commits September 9, 2023 10:56

cwd + namespace view

f592a9a

pdb conf

367ad52

faulthandler, mpl backend, special_kernel

e6fb0f2

color scheme

d2a56ee

don't send the same config several times

99c7420

publish after changing view

5a72041

remove setup kernel

a4f9678

impact27 mentioned this pull request Sep 9, 2023

PR: Simplify kernel configuration spyder-ide/spyder-kernels#466

Merged

fix callback

29540c3

impact27 changed the title ~~Group config calls~~ PR: Group config calls Sep 9, 2023

matplotlib and completer

2612389

impact27 force-pushed the group_config_calls branch from 330e582 to 2612389 Compare September 10, 2023 05:19

Quentin Peter and others added 18 commits September 10, 2023 13:41

use kernel infos

b7e88fd

typo

66e7fde

faster startup

b150b48

reset after crash

7e5fa4d

Merge remote-tracking branch 'upstream/master' into group_config_calls

c4e8058

Merge branch 'master' into group_config_calls

cac46f2

Merge branch 'master' into group_config_calls

60ceb1d

Merge branch 'master' into group_config_calls

9ae6683

fix handlers copy

5ec4901

Changing length

24810c5

matplotlib & special

5f1d7b9

fix loading

2bbf3b4

Merge branch 'matplotlibconf' into group_config_calls

2a17d0e

set_special_kernel

563d6a2

fix matplotlib

fb57194

fix sympy background

79055c7

enable cython

0796479

ccordoba12 assigned impact27 Nov 12, 2023

ccordoba12 changed the title ~~PR: Group config calls~~ PR: Group kernel config calls (IPython console) Nov 12, 2023

ccordoba12 reviewed Nov 12, 2023

View reviewed changes

Quentin Peter and others added 15 commits November 12, 2023 17:11

Revert "qdark"

9241211

This reverts commit 4512721.

Merge remote-tracking branch 'upstream/master' into group_config_calls

eb6588d

Apply suggestions from code review

6ffb578

Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>

qt5 to qt

880dd87

Merge remote-tracking branch 'origin/group_config_calls' into group_c…

9e3fac0

…onfig_calls

nt

0eba8fc

fix interactive logic

bf2fcc1

fix typo

f9dc7aa

use safe exec

8d154b1

special_kernel_error

8a204ae

CI: Install subrepo version of Spyder-kernels in env used to test act…

9c07bc8

…ivation

Quentin Peter added 2 commits November 15, 2023 07:38

Merge remote-tracking branch 'upstream/master' into group_config_calls

78d2442

ccordoba12 approved these changes Nov 16, 2023

View reviewed changes

ccordoba12 merged commit 193a59f into spyder-ide:master Nov 16, 2023
14 checks passed

ccordoba12 mentioned this pull request Sep 5, 2024

PR: Enable autoreload magic on all operating systems (Config) #22438

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR: Group kernel config calls (IPython console) #21320

PR: Group kernel config calls (IPython console) #21320

impact27 commented Sep 9, 2023 •

edited by ccordoba12

Loading

impact27 commented Nov 12, 2023

ccordoba12 left a comment

ccordoba12 commented Nov 12, 2023

ccordoba12 commented Nov 14, 2023 •

edited

Loading

ccordoba12 commented Nov 15, 2023 •

edited

Loading

impact27 commented Nov 15, 2023

ccordoba12 commented Nov 15, 2023 •

edited

Loading

ccordoba12 left a comment

PR: Group kernel config calls (IPython console) #21320

PR: Group kernel config calls (IPython console) #21320

Conversation

impact27 commented Sep 9, 2023 • edited by ccordoba12 Loading

Description of Changes

Issue(s) Resolved

Affirmation

impact27 commented Nov 12, 2023

ccordoba12 left a comment

Choose a reason for hiding this comment

ccordoba12 commented Nov 12, 2023

ccordoba12 commented Nov 14, 2023 • edited Loading

ccordoba12 commented Nov 15, 2023 • edited Loading

impact27 commented Nov 15, 2023

ccordoba12 commented Nov 15, 2023 • edited Loading

ccordoba12 left a comment

Choose a reason for hiding this comment

impact27 commented Sep 9, 2023 •

edited by ccordoba12

Loading

ccordoba12 commented Nov 14, 2023 •

edited

Loading

ccordoba12 commented Nov 15, 2023 •

edited

Loading

ccordoba12 commented Nov 15, 2023 •

edited

Loading