Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Fix KeyError issue with format in update worker #21548

Merged
merged 1 commit into from
Nov 24, 2023
Merged

PR: Fix KeyError issue with format in update worker #21548

merged 1 commit into from
Nov 24, 2023

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Nov 22, 2023 •
edited
Loading

Added keyword argument to string format method in order to resolve KeyError.

Issue(s) Resolved

Fixes #21546

@mrclary mrclary self-assigned this Nov 22, 2023
@mrclary mrclary requested a review from ccordoba12 November 22, 2023 19:31
@ccordoba12
Copy link
Member

Thanks for your prompt help @mrclary! Could you describe how this helps to solve issue #21546?

Also, to fix our tests please apply the changes in PR #21517, specifically those related to QDarkstyle.

@ccordoba12 ccordoba12 added this to the v5.5.1 milestone Nov 22, 2023
@mrclary
Copy link
Contributor Author

mrclary commented Nov 23, 2023

Also, to fix our tests please apply the changes in PR #21517, specifically those related to QDarkstyle.

🤔 The test environment was already using QDarkstyle 3.2.1; nevertheless, I applied the changes in #21517. However, the tests are still failing.

@ccordoba12
Copy link
Member

However, the tests are still failing.

It seems a test for the %edit magic started to fail. I don't know why, but I'll take a look at it.

For the conda-based Linux installer, please check what's happening. From the logs, it seems mamba is no longer available in the build env.

@ccordoba12 ccordoba12 changed the title Fix KeyError issue with format in update worker PR: Fix KeyError issue with format in update worker Nov 23, 2023
@ccordoba12
Copy link
Member

@mrclary, I fixed both the failing test and building our Linux installer (which was not so hard) on PR #21553.

So, please drop your last commit here and rebase on top of 5.x to get those fixes.

ccordoba12
ccordoba12 approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary!

@ccordoba12 ccordoba12 merged commit 739457e into spyder-ide:5.x Nov 24, 2023
22 checks passed
ccordoba12 added a commit that referenced this pull request Nov 24, 2023
@ccordoba12
Merge from 5.x: PR #21548
6e315af 
Fixes #21546
@mrclary mrclary deleted the issue-21546 branch November 28, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@mrclary mrclary

Labels
component:Main Window type:Bug
Projects
None yet
Milestone
v5.5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mrclary @ccordoba12