Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Unify kernel configuration #21903

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

PR: Unify kernel configuration #21903

wants to merge 7 commits into from

Conversation

impact27
Copy link
Contributor

@impact27 impact27 commented Mar 17, 2024 •
edited
Loading

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Unify two ways of changing the kernel configuration. This also avoids restarting the cached kernel if the options have been changed.

Issue(s) Resolved

Fixes #

Spyder-kernels: spyder-ide/spyder-kernels#483

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

Quentin Peter added 2 commits March 16, 2024 23:40
env vars
29b95d7
git subrepo clone --branch=envvar --force https://github.com/impact27…
a5f1a7c 
…/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "6316ca7ed"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "envvar"
  commit:   "6316ca7ed"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
@pep8speaks
Copy link

pep8speaks commented Mar 17, 2024 •
edited
Loading

Hello @impact27! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 28:1: E302 expected 2 blank lines, found 1
Line 33:28: W292 no newline at end of file

Comment last updated at 2024-03-17 08:10:36 UTC

@impact27 impact27 mentioned this pull request Mar 17, 2024
Open
Quentin Peter added 5 commits March 17, 2024 08:41
rename return value
7edbff5
add set_
760accf
git subrepo clone --branch=envvar --force https://github.com/impact27…
b9dee74 
…/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "73ff0e8ac"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "envvar"
  commit:   "73ff0e8ac"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
Merge remote-tracking branch 'upstream/master' into moveenvvars
c877535
git subrepo clone --branch=envvar --force https://github.com/impact27…
0744177 
…/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "6e7ddbc21"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "envvar"
  commit:   "6e7ddbc21"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@impact27 @pep8speaks