PR: Fix shortcuts for several Run and Debugger actions #22230
Conversation
- Improve how shortcuts are registered in widgets. - Use that mixin in other places where we need to get/set shortcuts. - Remove code related to shortcuts from SpyderConfigurationAccessor - Remove unnecessary code related to the old way of registering shortcuts for widgets.
|
Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-07-06 15:41:45 UTC |
ccordoba12
changed the title
- Also make run cell and selection in debugger shortcuts work only for the editor. - And set a new shortcut for run selection in debugger.
And remove it from the Online Help.
That code is not necessary anymore.
Also, remove unnecessary calls to shortcuts.apply_shortcuts()
That was computed correctly if the Debugger is not focused at startup.
ccordoba12
force-pushed
the
fix-run-debugger-shortcuts
branch
from
0cb4a19
to
f077988
Compare
|
@dalthviz, this is ready for review. |
|
Gave this an initial check and seems like there are missing changes to cover shortcuts for plugins like Code Analysis and Profiler? With this I'm unable to trigger via shortcuts the profiler ( |
- That's necessary to create EditorMainWindow's independently of the Editor (e.g. for testing). - Also, fix a test related to shortcuts and add a clarifying comment.
ccordoba12
force-pushed
the
fix-run-debugger-shortcuts
branch
from
f077988
to
4a3a5fd
Compare
That's right, I didn't check those shortcuts. But they should be working now, so please test again. |
|
Note: Could this be related with #14403 ? |
|
Yep, that's mostly the same problem. But in the case of the Editor, the thing is that And we can't create It's a tricky problem that we have to think better. For now I think what I did is just a stopgap solution. |
There was a problem hiding this comment.
Thanks @ccordoba12 ! Checked locally and seems like things are working, so this LGTM 👍
Description of Changes
Run cell,Run cell and advanceand other Run actions, as well asnext,continueand other Debugger actions, local to the Editor again.SpyderShortcutsMixintospyder.api.shortcutsand use it to simplify the way shortcuts are registered for widgets. That's necessary when a widget is not a direct child of the one where an action with shortcut was created (e.g. theEditorStackwith respect toEditorMainWidget).Ctrl+Shift+Das the new shortcut to go to the Debugger (and remove that shortcut for the Online Help).array_buildertoeditor. That follows the convention already used in the IPython console.Note
There's still a limitation (also present in Spyder 5) with shortcuts registered for widgets: they are not updated after a change in Preferences. I tried to fix that as part of this PR but it requires several changes to the way shortcut options are tracked and notified, so I prefer to leave it for a follow-up one.
Issue(s) Resolved
Fixes #21129.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12