PR: Check spyder-remote-services version compatibility (Remote client)
#22860
+94
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @hlouzada! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-11-25 20:53:30 UTC |
ccordoba12
changed the title
spyder-remote-services version compatibility (Remote client)
|
@hlouzada, please rebase on top of master to make our tests on Mac pass. |
hlouzada
force-pushed
the
add-remoteclient-version
branch
from
39e741f
to
6a9fe49
Compare
ccordoba12
force-pushed
the
add-remoteclient-version
branch
from
fbdb917
to
2509991
Compare
ccordoba12
reviewed
Nov 7, 2024
CAM-Gerlach
reviewed
Nov 11, 2024
CAM-Gerlach
approved these changes
Nov 14, 2024
- This matches where the Spyder-kernels version constants are placed for the IPython console. - Also, remove a couple of constants that are unnecessary.
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
hlouzada
force-pushed
the
add-remoteclient-version
branch
from
8203e0b
to
2fd03ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Modify server installation check and ensure server methods to check whether the spyder server version is compatible and updatable or display an error.
Visual changes
Show message when there's a mismatch between the Spyder and spyder-remote-services versions
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @hlouzada