-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Missing dark style for QMenus, Tour, Pylint, Profiler and DataFrameEditor #8201
Conversation
Hello @dalthviz! Thanks for updating the PR.
Comment last updated on November 06, 2018 at 23:50 Hours UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dalthviz! It looks good, but we need to avoid hard-coding colors and use constants, like MAIN_FG_COLOR
.
38cae91
to
4ab65ca
Compare
@ccordoba12 a preview: Interactive tour and menusOutline Explorer code cell namesDataFrameEditor Index columnPlots pluginPylintProfiler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a bit of refactoring but otherwise looks good. Thanks @dalthviz!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dalthviz, I think we can refactor things even more. Please see my comment below and sorry for making you waste time with this, it just occurred to me right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dalthviz, looks good now!
Pull Request Checklist
modified the
spyder/defaults
directory, or added new icons/assetsDeveloper Certificate of Origin Affirmation
By submitting this Pull Request or typing my name below, I affirm the
I certify the above statement is true and correct: dalthvizDeveloper Certificate of Origin
with respect to both the content of the contribution itself and this post,
and understand I am releasing it under Spyder's MIT (Expat) license.
Description of Changes
Apply dark style sheet to QMenus, and elements of the Tour, Pylint, Profiler and DataFrameEditor
Issue(s) Resolved
Part of #8068