Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Missing dark style for QMenus, Tour, Pylint, Profiler and DataFrameEditor #8201

Merged
merged 5 commits into from
Nov 15, 2018

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Nov 6, 2018

Pull Request Checklist

  • Read and followed this repo's Contributing Guidelines
  • Based this PR on the latest version of the correct branch (master or 3.x)
  • Followed PEP 8 code style
  • Ensured this pull request hasn't eliminated unrelated blank lines/spaces,
    modified the spyder/defaults directory, or added new icons/assets
  • Described the changes and the motivation for them below
  • Noted what issue(s) this pull request resolves, creating one if needed
  • Included a screenshot, if this PR makes any visible changes to the UI

Developer Certificate of Origin Affirmation

By submitting this Pull Request or typing my name below, I affirm the
Developer Certificate of Origin
with respect to both the content of the contribution itself and this post,
and understand I am releasing it under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

Description of Changes

Apply dark style sheet to QMenus, and elements of the Tour, Pylint, Profiler and DataFrameEditor

Issue(s) Resolved

Part of #8068

@pep8speaks
Copy link

pep8speaks commented Nov 6, 2018

Hello @dalthviz! Thanks for updating the PR.

Comment last updated on November 06, 2018 at 23:50 Hours UTC

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz! It looks good, but we need to avoid hard-coding colors and use constants, like MAIN_FG_COLOR.

spyder/app/tour.py Outdated Show resolved Hide resolved
spyder/plugins/profiler/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/profiler/widgets/profilergui.py Outdated Show resolved Hide resolved
spyder/plugins/pylint/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/pylint/widgets/pylintgui.py Outdated Show resolved Hide resolved
@dalthviz
Copy link
Member Author

dalthviz commented Nov 6, 2018

@ccordoba12 a preview:

Interactive tour and menus

imagen
imagen

Outline Explorer code cell names

imagen
imagen

DataFrameEditor Index column

imagen
imagen

imagen

imagen

Plots plugin

imagen
imagen

Pylint

imagen
imagen

Profiler

imagen
imagen

@dalthviz dalthviz changed the title [WIP] PR: Missing dark style for QMenus, Tour, Pylint, Profiler and DataFrameEditor PR: Missing dark style for QMenus, Tour, Pylint, Profiler and DataFrameEditor Nov 6, 2018
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a bit of refactoring but otherwise looks good. Thanks @dalthviz!

spyder/app/tour.py Outdated Show resolved Hide resolved
spyder/app/tour.py Outdated Show resolved Hide resolved
spyder/app/tour.py Outdated Show resolved Hide resolved
spyder/app/tour.py Outdated Show resolved Hide resolved
spyder/app/tour.py Outdated Show resolved Hide resolved
spyder/app/tour.py Outdated Show resolved Hide resolved
spyder/plugins/plots/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/profiler/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/pylint/plugin.py Outdated Show resolved Hide resolved
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dalthviz, I think we can refactor things even more. Please see my comment below and sorry for making you waste time with this, it just occurred to me right now.

spyder/app/tour.py Outdated Show resolved Hide resolved
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz, looks good now!

@ccordoba12 ccordoba12 merged commit 883a9bd into spyder-ide:master Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants