Skip to content

Convert to pyproject.toml project file #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DeflateAwning opened this issue Mar 15, 2025 · 2 comments · Fixed by #63
Closed

Convert to pyproject.toml project file #60

DeflateAwning opened this issue Mar 15, 2025 · 2 comments · Fixed by #63

Comments

@DeflateAwning
Copy link
Contributor

DeflateAwning commented Mar 15, 2025

Would it be okay if I converted the old setup.py project configuration to pyproject.toml with the Hatchling build system (as is currently the recommended way to ship projects)?

I'll do the work and submit a PR, but only if you pre-approve it here.

@spyoungtech
Copy link
Owner

Hmm. I appreciate the suggestion, but I'm not sure it's a necessary change. I suppose it couldn't hurt to move to pyproject.toml and I would accept that change if you wanted to make a PR for it, but I don't see a reason to use hatchling as the build backend and would prefer to avoid that.

Thanks!

@DeflateAwning
Copy link
Contributor Author

Reason: Using modern python tooling, which does not depend on old/outdated reasons. https://hatch.pypa.io/1.7/why/

Will prepare the move to pyproject.toml with setuptools though.

This originally came up because I wanted to clean up the PyPI entry, but am not too familiar with debugging the old setuptools configurations

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants