Switch setup.py/.cfg to pyproject.toml, add docs link/readme #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spyoungtech
reviewed
Mar 17, 2025
| name = "FreeSimpleGUI" | ||
| version = "5.2.0" | ||
| description = "The free-forever Python GUI framework." | ||
| readme = {file = "README.md", content-type = "text/markdown"} |
There was a problem hiding this comment.
In the original setup.cfg, I believe this was a typo. Probably why the description doesn't show on PyPI. Let's correct it here.
Suggested change
| readme = {file = "README.md", content-type = "text/markdown"} | |
| readme = {file = "readme.md", content-type = "text/markdown"} |
Alternatively, we can rename readme.md to README.md.
|
Great catch, thanks! Just renamed the README to the standard |
|
Awesome. Thanks for the contribution. I'll try and get a post release out shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.pyandsetup.cfgtopyproject.toml. Maintained the setuptools build system though, instead of switching to something like Hatch (as discussed in Convert topyproject.tomlproject file #60)Fixes #60