-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests failing with *** should be the URI without the password #744
Labels
Comments
This is because libwww-perl/URI#13 was fixed this week (after almost 10 years!). Will have to modify the tests to allow the |
theory
added a commit
that referenced
this issue
May 10, 2023
When there is a username but no password, URI used to leave an orphan colon in the URI (reported in libwww-perl/URI#13). That bug was fixed in libwww-perl/URI#31, leading to failures in Sqitch tests expecting the colon to be present. So change the tests to use a regular expression to match such URIs, so that the presence of the colon is optional. Resolves #744.
theory
added a commit
that referenced
this issue
May 10, 2023
When there is a username but no password, URI used to leave an orphan colon in the URI (reported in libwww-perl/URI#13). That bug was fixed in libwww-perl/URI#31, leading to failures in Sqitch tests expecting the colon to be present. libwww-perl/URI-db#23 also changed the DSN of URI::Oracle to specify the database name with `service_name=`. So change the tests to use regular expressions to match such URIs and DSNs, so that the presence of the colon or service name is optional. Resolves #744.
theory
added a commit
that referenced
this issue
May 10, 2023
When there is a username but no password, URI used to leave an orphan colon in the URI (reported in libwww-perl/URI#13). That bug was fixed in libwww-perl/URI#31, leading to failures in Sqitch tests expecting the colon to be present. libwww-perl/URI-db#23 also changed the DSN of URI::Oracle to specify the database name with `service_name=`. So change the tests to use regular expressions to match such URIs and DSNs, so that the presence of the colon or service name is optional. Resolves #744.
theory
added a commit
that referenced
this issue
May 10, 2023
When there is a username but no password, URI used to leave an orphan colon in the URI (reported in libwww-perl/URI#13). That bug was fixed in libwww-perl/URI#31, leading to failures in Sqitch tests expecting the colon to be present. libwww-perl/URI-db#23 also changed the DSN of URI::Oracle to specify the database name with `service_name=`. So change the tests to use regular expressions to match such URIs and DSNs, so that the presence of the colon or service name is optional. Resolves #744.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm seeing only these tests fail when building Sqitch 1.3.1 and Sqitch 1.3.0. In the past I've built these images without any issues, are there some dependencies that have been updated recently and changed the behavior of how URI passwords are handled?
Here's my docker file:
The text was updated successfully, but these errors were encountered: