Allow BETWEEN operator to be followed by AND operator #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a long-standing bug which resulted in ambiguous grammar. The solution involves adding multiple new parser rules which exclude the AND/OR/XOR operators from expressions inside the BETWEEN-expression. This solution is far from elegant. Really it's plain ugly, but at least it gets the bug fixed. I think there's no good way to fix it in the current parser/formatter architecture. Fixes #534
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a long-standing bug which resulted in ambiguous grammar.
The solution involves adding multiple new parser rules which exclude the AND/OR/XOR operators from expressions inside the BETWEEN-expression.
This solution is far from elegant. Really it's plain ugly, but at least it gets the bug fixed. I think there's no good way to fix it in the current parser/formatter architecture.
Fixes #534