Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support named config file #766

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Support named config file #766

merged 3 commits into from
Aug 9, 2024

Conversation

schusj
Copy link
Contributor

@schusj schusj commented Aug 9, 2024

Closes 760 (no, does not)

Copy link

codesandbox-ci bot commented Aug 9, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Collaborator

@nene nene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Looks like a nice little addition. I've added a few small comments, feel free to fix them if you feel like it. Otherwise I'll merge it as-is.

I should also point out that this does not actually resolve issue #760. That one is about VSCode extension, but the logic in bin/sql-formatter-cli.cjs is used only by the sql-formatter command line tool and won't in any way impact the VSCode extension which only uses the sql-formatter library (source of which resides in src/ dir).

bin/sql-formatter-cli.cjs Outdated Show resolved Hide resolved
bin/sql-formatter-cli.cjs Outdated Show resolved Hide resolved
@schusj
Copy link
Contributor Author

schusj commented Aug 9, 2024

Oh okay, I use the CLI with neovim and just assumed #760 was related / could be solved with this. Have resolved your comments.

@nene nene merged commit bfe753c into sql-formatter-org:master Aug 9, 2024
2 checks passed
@nene
Copy link
Collaborator

nene commented Aug 9, 2024

This is now released in 15.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants