Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes yarn.lock for yarn check verification #799

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

tonycoco
Copy link
Contributor

@tonycoco tonycoco commented Nov 7, 2024

yarn.lock failed to pass yarn check. This fixes it without direct dependency modifications.

Copy link

codesandbox-ci bot commented Nov 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@nene
Copy link
Collaborator

nene commented Nov 8, 2024

Thanks for the PR.

Would you care to explain how did you achieve this? That is, I guess you didn't go through all the warnings one-by-one to resolve them, but did it in some automated way.

I'm also not sure what you mean by "without dependency modifications". Your PR definitely contains lots of changes to the dependencies listed in yarn.lock file.

@tonycoco
Copy link
Contributor Author

tonycoco commented Nov 8, 2024

Ahh yes, sorry, meant to say no direct dependencies changed. Underlying deps that were removed, outdated, or had critical fixes were changed so that yarn check works again. I did it by re-generating a yarn.lock file. I noticed the errors since a few projects I work on used sql-formatter as a pre-commit hook.

@nene
Copy link
Collaborator

nene commented Nov 9, 2024

Thanks for the explanation. Much appreciated!

@nene nene merged commit 0875b8c into sql-formatter-org:master Nov 9, 2024
2 checks passed
@tonycoco
Copy link
Contributor Author

@nene can you bump the version for this change? pre-commit needs a rev to apply the fix here

@nene
Copy link
Collaborator

nene commented Nov 12, 2024

No problem. Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants