reference tensor proto of tensorflow #1729
Conversation
elasticdl/Makefile
Outdated
|
|
||
| $(GO_PB_FILE): $(EDL_PROTO_FILE) | ||
| go_pb: |
There was a problem hiding this comment.
This target requires at least one dependent ${PROTO_PATH}/elasticdl.proto
go_pb: elasticdl/proto/elasticdl.proto
...
elasticdl/Makefile
Outdated
| CXX = g++ | ||
| CAPI_DIR = elasticdl/pkg/kernel/capi | ||
|
|
||
| all: python_pb $(GO_PB_FILE) kernel | ||
| all: python_pb go_pb kernel | ||
|
|
||
| python_pb: |
There was a problem hiding this comment.
This target requires at least ${PROTO_PATH}/elasticdl.proto as its dependent.
python_pb: elasticdl/proto/elasticdl.proto
...
elasticdl/Makefile
Outdated
|
|
||
| EDL_PROTO_FILE = elasticdl/proto/elasticdl.proto | ||
|
|
||
| PROTO_PATH=elasticdl/proto |
There was a problem hiding this comment.
I prefer we don't define this variable, as its naming doesn't add much information. Instead, we could literally use elasticdl/proto in the following rules.
| @@ -49,11 +49,11 @@ RUN /install-protobuf.bash && rm /install-protobuf.bash | |||
|
|
|||
| # Install elasticdl.org/elasticdl Go package | |||
| ENV ELASTICDLPATH $GOPATH/src/elasticdl.org/elasticdl | |||
| ENV TF_PATH /tmp/tensorflow | |||
| RUN cd /tmp && git clone --depth=1 https://github.com/tensorflow/tensorflow.git | |||
There was a problem hiding this comment.
Adding this line would significantly slow down the Docker build speed. @QiJune please follow up #1731 with @typhoonzero to use Docker build cache as much as possible.
There was a problem hiding this comment.
@wangkuiyi I compare two CI time of two PRs, PR 1726 and current PR
- PR 1726: 6min 15s + 17min 34s = 23min 49s
- current PR: 6min 6s + 16min 49s = 22min 55s
22min 55s is smaller than 23min 49s. It seems that downloading tensorflow will not influence the CI speed.
I usegit clone --depth=1, so the downloading speed will be fast.
Fix #1728