Skip to content

update _config.yml and fix some out-dated link #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2020
Merged

update _config.yml and fix some out-dated link #102

merged 2 commits into from
Apr 14, 2020

Conversation

lhw362950217
Copy link
Collaborator

update sqlflow.io's doc index, prepare to update the website

@lhw362950217 lhw362950217 requested review from shendiaomo, weiguoz, typhoonzero and QiJune and removed request for QiJune April 13, 2020 13:56
shendiaomo
shendiaomo previously approved these changes Apr 13, 2020
QiJune
QiJune previously approved these changes Apr 14, 2020
Copy link
Collaborator

@QiJune QiJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

_config.yml Outdated
values:
nav_exclude: false
parent: ElasticDL
nav_order: 2
- scope:
path: "elasticdl/doc/tutorials/elasticdl_cloud.md"
path: "elasticdl/docs/tutorials/elasticdl_cloud.md"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use this file instead of elasticdl_cloud.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/tutorials/get_started.md.

And we can put this file in the first order of ElasticDL.

_config.yml Outdated
@@ -303,66 +363,60 @@ defaults:
grand_parent: SQLFlow
nav_order: 3
- scope:
path: "elasticdl/doc/data_preparation_design.md"
path: "elasticdl/docs/designs/data_preparation.md"
Copy link

@brightcoder01 brightcoder01 Apr 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to publish the following documents for elasticdl. And the order in the website is also the same as follows:

https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/tutorials/get_started.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/overall.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/high_level_api.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/dynamic_data_sharding.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/concepts.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/parameter_server.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/high_performance_ps.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/distributed_embedding_layer.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/allreduce.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/elastic_sync_sgd.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/async_sgd.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/checkpoint_design.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/model_serving.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/keras_callback.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/data_preparation.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/data_io_pipeline.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/data_transform.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/sqlflow_integration.md

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@lhw362950217 lhw362950217 dismissed stale reviews from QiJune and shendiaomo via 8cd3c09 April 14, 2020 08:50
Copy link
Collaborator

@shendiaomo shendiaomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@lhw362950217 lhw362950217 merged commit 02f7e14 into sql-machine-learning:master Apr 14, 2020
Yancey0623 added a commit that referenced this pull request Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants