-
Notifications
You must be signed in to change notification settings - Fork 12
update _config.yml and fix some out-dated link #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update _config.yml and fix some out-dated link #102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
_config.yml
Outdated
values: | ||
nav_exclude: false | ||
parent: ElasticDL | ||
nav_order: 2 | ||
- scope: | ||
path: "elasticdl/doc/tutorials/elasticdl_cloud.md" | ||
path: "elasticdl/docs/tutorials/elasticdl_cloud.md" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use this file instead of elasticdl_cloud.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/tutorials/get_started.md.
And we can put this file in the first order of ElasticDL.
_config.yml
Outdated
@@ -303,66 +363,60 @@ defaults: | |||
grand_parent: SQLFlow | |||
nav_order: 3 | |||
- scope: | |||
path: "elasticdl/doc/data_preparation_design.md" | |||
path: "elasticdl/docs/designs/data_preparation.md" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose to publish the following documents for elasticdl. And the order in the website is also the same as follows:
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/tutorials/get_started.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/overall.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/high_level_api.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/dynamic_data_sharding.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/concepts.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/parameter_server.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/high_performance_ps.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/distributed_embedding_layer.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/allreduce.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/elastic_sync_sgd.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/async_sgd.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/checkpoint_design.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/model_serving.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/keras_callback.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/data_preparation.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/data_io_pipeline.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/data_transform.md
https://github.com/sql-machine-learning/elasticdl/blob/develop/docs/designs/sqlflow_integration.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
This reverts commit 02f7e14.
update sqlflow.io's doc index, prepare to update the website