xgboost/sqlflow_data_source #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Yancey0623
reviewed
Aug 11, 2019
| raise XGBoostError('invalid shape %s of FeatureMeta' % value) | ||
|
|
||
|
|
||
| class SqlflowDSConfig(typing.NamedTuple): |
There was a problem hiding this comment.
SqlflowDSConfig can be capital to SQLFlowDSConfig.
| conn=conn, | ||
| statement=source_conf.standard_select, | ||
| feature_column_names=col_names, | ||
| label_column_name=None, |
There was a problem hiding this comment.
Just confusion why the label column is None.
There was a problem hiding this comment.
Because all column fields in use have already been included in feature_column_names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is setup sqlflow_data_source for xgoost_on_sqlflow, who serves as the bridge of
sqlflow.dbandxgboost-launcher.related issue: #630