Implement ExecuteSQLOp.to_diff_tuple, fixes #1335 #1336
Conversation
This implements ExecuteSQLOp.to_diff_tuple, which is necessary when custom SQL statements are added to the diff stream via some hook.
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 4ec6638 of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change 4ec6638: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4914 |
|
great, looks like you filled out the whole format/changelog, thanks |
|
this is currently failing CI for a few small reasons - are you able to check out the failures for SQLA 1.3 and pep8 over at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4914 on the left side? |
|
@zzzeek should be fixed now, can you please trigger another CI run? |
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision c5e217e of this pull request into gerrit so we can run tests and reviews and stuff
|
Patchset c5e217e added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4914 |
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4914 has been merged. Congratulations! :) |
Description
This implements ExecuteSQLOp.to_diff_tuple, which is necessary when custom SQL statements are added to the diff stream via some hook.
Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>in the commit messageHave a nice day!