-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed legacy py2 __future__ directive #244
Conversation
Change-Id: I82656f9c9fa8b9e136b4b31a878514b83d7d6888
that was the only one? OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 6daee2f of this pull request into gerrit so we can run tests and reviews and stuff
New Gerrit review created for change 6daee2f: https://gerrit.sqlalchemy.org/c/sqlalchemy/dogpile.cache/+/4876 |
For this, yes. I did a second check, and there are two files with:
That has been standard since Python 2.6 I can drop those in this PR or do another. (I didn't think of searching for all future earlier, just this one) |
just update this PR with new commits |
which has been standard since Python2.5 see https://docs.python.org/3/library/__future__.html Change-Id: I5559cf7b2976f1e98d432c0ceddb15aab2ca151d
done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 84ec326 of this pull request into gerrit so we can run tests and reviews and stuff
Patchset 84ec326 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/dogpile.cache/+/4876 |
mike bayer (zzzeek) wrote: thanks! View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/dogpile.cache/+/4876 |
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/dogpile.cache/+/4876 has been merged. Congratulations! :) |
see #243