Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline comments with control statements #53

Closed
sqlalchemy-bot opened this issue Jul 20, 2007 · 3 comments
Closed

inline comments with control statements #53

sqlalchemy-bot opened this issue Jul 20, 2007 · 3 comments

Comments

@sqlalchemy-bot
Copy link

Migrated issue, originally created by Michael Bayer (@zzzeek)

I thought this worked, but apparently it does not:

% if foo:   # check for 'foo'

would be a good lexer enhancement.


Attachments: mako_comment_lex.diff

@sqlalchemy-bot
Copy link
Author

Anonymous wrote:

Look at attached patch.
I've tried to split statement and control in the lexer but then code like following would be a problem:

  % if a = '#':

I don't think attached solution would be a problem.

@sqlalchemy-bot
Copy link
Author

Michael Bayer (@zzzeek) wrote:

just had to adjust one unit test which relied upon that parsing as an error, and they all pass. as a bonus, you get to be unit test #200. great job, it'll be out in 0.1.9 and its [changeset:302].

@sqlalchemy-bot
Copy link
Author

Changes by Michael Bayer (@zzzeek):

  • changed status to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant