Use Constant.value, not Constant.n #292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Python 3.8, class ast.Constant is used for all constants. Old classes ast.Num, ast.Str, ast.Bytes, ast.NameConstant and ast.Ellipsis are still available, but they will be removed in future Python releases. Constants have values, but not always ns. See sqlalchemy#287 (comment) See python/cpython#9445 Fixes Pylons/pyramid_mako#47
This was referenced Apr 11, 2019
|
OK we can't really test reasonably, source code inspection reveals Constant.n Constant.s are completely bogus im not sure why they added them |
sqla-tester
reviewed
Apr 11, 2019
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work to try to get revision b48081a of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change b48081a: https://gerrit.sqlalchemy.org/#/c/sqlalchemy/mako/+/1188 |
|
mike bayer (zzzeek) wrote: Verified+1 Code-Review+2 Workflow+1 |
|
Gerrit review https://gerrit.sqlalchemy.org/1188 has been merged. Congratulations! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Python 3.8, class ast.Constant is used for all constants.
Old classes ast.Num, ast.Str, ast.Bytes, ast.NameConstant and
ast.Ellipsis are still available, but they will be removed in
future Python releases.
Constants have values, but not always ns.
See #287 (comment)
See python/cpython#9445
Fixes Pylons/pyramid_mako#47