Inflection Singular table names exclusion configuration #1531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add python and go tests
kyleconroy
requested changes
Aug 29, 2022
Collaborator
kyleconroy
left a comment
kyleconroy
left a comment
There was a problem hiding this comment.
The code looks good, but I think you're right that exclude_table_names isn't a good name. I'll think about some alternatives that we can use.
Collaborator
|
Let's go with inflection_exclude_table_names. It's still not great, but I want to unblock us. |
kyleconroy
approved these changes
Aug 29, 2022
Collaborator
|
@danicc097 You'll need to rebase as the configuration / proto files have changed. |
kyleconroy
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1526
Not a fan of
exclude_table_namesbeing so ambiguous, butemit_exact_table_namesis already taken. Any ideas for that or is it good enough?