Skip to content

Add support for CHANGE COLUMN in MySQL #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2022
Merged

Add support for CHANGE COLUMN in MySQL #1605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions internal/endtoend/testdata/ddl_alter_table_change_column/mysql/go/db.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 13 additions & 0 deletions internal/endtoend/testdata/ddl_alter_table_change_column/mysql/go/models.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 19 additions & 0 deletions internal/endtoend/testdata/ddl_alter_table_change_column/mysql/go/query.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions internal/endtoend/testdata/ddl_alter_table_change_column/mysql/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
/* name: Placeholder :exec */
SELECT 1;
2 changes: 2 additions & 0 deletions internal/endtoend/testdata/ddl_alter_table_change_column/mysql/schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
CREATE TABLE foo (bar text);
ALTER TABLE foo CHANGE COLUMN bar baz text;
12 changes: 12 additions & 0 deletions internal/endtoend/testdata/ddl_alter_table_change_column/mysql/sqlc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"version": "1",
"packages": [
{
"path": "go",
"engine": "mysql",
"name": "querytest",
"schema": "schema.sql",
"queries": "query.sql"
}
]
}
24 changes: 23 additions & 1 deletion internal/engine/dolphin/convert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,29 @@ func (c *cc) convertAlterTableStmt(n *pcast.AlterTableStmt) ast.Node {
})

case pcast.AlterTableChangeColumn:
// spew.Dump("change column", spec)
oldName := spec.OldColumnName.String()
alt.Cmds.Items = append(alt.Cmds.Items, &ast.AlterTableCmd{
Name: &oldName,
Subtype: ast.AT_DropColumn,
})

for _, def := range spec.NewColumns {
name := def.Name.String()
columnDef := ast.ColumnDef{
Colname: def.Name.String(),
TypeName: &ast.TypeName{Name: types.TypeStr(def.Tp.Tp)},
IsNotNull: isNotNull(def),
}
if def.Tp.Flen >= 0 {
length := def.Tp.Flen
columnDef.Length = &length
}
alt.Cmds.Items = append(alt.Cmds.Items, &ast.AlterTableCmd{
Name: &name,
Subtype: ast.AT_AddColumn,
Def: &columnDef,
})
}

case pcast.AlterTableModifyColumn:
for _, def := range spec.NewColumns {
Expand Down