feat: Codegen plugins, powered by WASM #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kyleconroy
commented
Jun 16, 2022
•
kyleconroy
commented
- Pick a system-wide cache
- Verify checksums
- Cache WASM files
- Cache modules
kyleconroy
changed the title
Only do the compilcation once
Make sure we don't try to share these modules across os / arch
kyleconroy
commented
Jun 22, 2022
Comment on lines
24
to
25
| "url": "file:///Users/kyle/Downloads/sqlc-gen-json-wasm.wasm", | ||
| "checksum": "sha256/afc486dac2068d741d7a4110146559d12a013fd0286f42a2fc7dcd802424ad07" |
There was a problem hiding this comment.
Obviously will need to update this to a URL
Comment on lines
+32
to
+36
| home, err := os.UserHomeDir() | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
| return filepath.Join(home, "sqlc", "mod"), nil |
There was a problem hiding this comment.
Need to look at the XDG spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.