Skip to content

codegen: surface batch validation errors #1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

codegen: surface batch validation errors #1924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion internal/sql/validate/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,10 @@ func validateCopyfrom(n ast.Node) error {
}

func validateBatch(n ast.Node) error {
nums, _, _ := ParamRef(n)
nums, _, err := ParamRef(n)
if err != nil {
return err
}
if len(nums) == 0 {
return errors.New(":batch* commands require parameters")
}
Expand Down
2 changes: 1 addition & 1 deletion internal/sql/validate/param_ref.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ func ParamRef(n ast.Node) (map[int]bool, bool, error) {
}
}), n)
if dollar && nodollar {
return nil, false, errors.New("Can not mix $1 format with ? format")
return nil, false, errors.New("can not mix $1 format with ? format")
}

seen := map[int]bool{}
Expand Down