MySQL support #230
Merged
MySQL support #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial commit of sql schema validation * adds barebones support for most basic use-case * improves parsing and generation of params * adds decent tests for mysql * improves param implementation - adds tests - adds support for named params - adds support for Limit expressions * adds support for decimal types * resolves some testing issues * generalizes imports * adds null type tests * improves go struct generation * adds command line call to mysql generate * improves support for insert queries and adds tests * improves support for enum types * refactors config to function param * patchs pkg settings arguments * simplifies and improves param parsing * param implementation and test patches * patch placeholder default table * properly handles "select * " expressions * initial commit of sql schema validation * adds barebones support for most basic use-case * improves parsing and generation of params * adds decent tests for mysql * improves param implementation - adds tests - adds support for named params - adds support for Limit expressions * adds support for decimal types * resolves some testing issues * generalizes imports * adds null type tests * improves go struct generation * adds command line call to mysql generate * improves support for insert queries and adds tests * improves support for enum types * refactors config to function param * patchs pkg settings arguments * simplifies and improves param parsing * param implementation and test patches * patch placeholder default table * properly handles "select * " expressions
MySQL Support
Each package now has a `database` field, which can be set to either `mysql` or `postgresql`.
Merged
|
@cmoog I think I'm ready to merge this in. Mind taking a look at my new commits? |
|
@kyleconroy Nice. Your new commits look great. |
Yeah, I think that's fine to add later. MySQL support will be marked as experimental |
|
Partial fix for #150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{ "version": "1", "packages": [ { "name": "bar", "engine": "mysql", "path": "internal/bar", "queries": "./sql/query/", "schema": "./sql/schema/" } ] }TODO:
--database