config: Add support for YAML #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both version 1 and version 2 of the config formats can now be expressed in YAML. sqlc will look for `sqlc.yaml` defined in the working directory.
kyleconroy
commented
Feb 12, 2020
| @@ -46,7 +46,8 @@ func TestBadConfigs(t *testing.T) { | |||
| }, | |||
| { | |||
| "unknown fields", | |||
| "json: unknown field \"foo\"", | |||
| `yaml: unmarshal errors: | |||
There was a problem hiding this comment.
I'm not happy about this error changing. Going forward, we shouldn't be exposing an error message directory from a dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both version 1 and version 2 of the config formats can now be expressed
in YAML. sqlc will look for
sqlc.yamldefined in the working directory.Fixes #330