Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect generate model names for "metadata" suffix #3553

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

qanghaa
Copy link

@qanghaa qanghaa commented Aug 18, 2024

@qanghaa qanghaa force-pushed the fix/incorrect_generate_model_names branch from 93e3bac to 853d233 Compare August 18, 2024 07:56
@qanghaa qanghaa force-pushed the fix/incorrect_generate_model_names branch from 853d233 to 89c110b Compare August 18, 2024 07:58
Comment on lines 7 to 9
type Bonuse struct {
ID string
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to still be wrong here?

Copy link
Author

@qanghaa qanghaa Oct 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, I just deleted this one from PR 👍

@qanghaa qanghaa changed the title Fix incorrect generate model names for "bonuses" and "metadata" suffix Fix incorrect generate model names for "metadata" suffix Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table "product_metadata" incorrectly generates model name.
2 participants